[18.0][MIG] base_location_geonames_import:Migration to 18.0 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for states (if states are already present in res.country.state). Add POT file and FR translation. Allow to skip entries in the _prepare method. Insist on the fact that the wizard deletes current better zip entries in the module description and in the wizard itself. Better error message when the country code inside the file is wrong. Add a FOR UPDATE NOWAIT at the beginning of the transaction. Remove France-specific code ; moved to new module l10n_fr_base_location_geonames_import on lp:openerp-french-localization Add module base_location_geonames_import Add support for states (if states are already present in res.country.state). Add POT file and FR translation. Allow to skip entries in the _prepare method. Insist on the fact that the wizard deletes current better zip entries in the module description and in the wizard itself. Better error message when the country code inside the file is wrong. Add a FOR UPDATE NOWAIT at the beginning of the transaction. Remove France-specific code ; moved to new module l10n_fr_base_location_geonames_import on lp:openerp-french-localization
…rec_name defined on better.zip.geonames.import [REF] porting to new api [IMP] removing 'FOR UPDATE NOWAIT' as ROW EXCLUSIVE lock is already acquired by DELETE and INSERT http://www.postgresql.org/docs/9.2/static/explicit-locking.html [REF] select_or_create_state and tests [FIX] __openerp__.py PEP8 [FIX] TypeError: unlink() got multiple values for keyword argument 'context' [IMP] using ir.config_parameter for geonames URL [FIX] missing cr uid
…ooks * Added Icon. * Improve module description and extracted to README.rst. * Pass country instead of country_id for advance comparisons. * Allow to transform city name. * Some code style. * Do not remove all entries of a country, but only not found. * Include hooks for transforming some things. * Include spanish translation. [FIX] base_location_geonames_import: Use self.env and recordsets
OCA requirements
[IMP] base_location_geonames_import: Make tests more efficient [FIX] base_location_geonames_import: Don't alias Warning [IMP] base_location_geonames_import: Convert tests to Python + switch imported country Monaco country is very little and it allows to save some downloaded bytes plus making a test for entries deletion [IMP] base_location_geonames_import: Switch author [FIX] base_location_geonames_import: Fix test [FIX] base_location_geonames_import: Fix tests [MIG] Make modules uninstallable [MIG] Rename manifest files [FIX] base_location_geonames_import: Test logic changed For avoiding constant problems with this test, as Monaco data changes a lot, what we are testing now is the existence of the data, not the exact match of them.
Add option to put city name all upper case
* Tests * New menu location * Wizard options fixed [IMP] base_location_geonames_import * Speed improvement applying cache for not doing duplicated searches over states. * Tests change to SavepointCase, which only passes over setUp one time.
* [IMP] base_location: Add lat & long to `better.zip` * Add latitude and longitude columns to `better.zip` * [IMP] base_location_geonames_import: Add lat/long * Add support for latitude & longitude to genomes importer
…umns based on country_id (OCA#534)
Generated new readme. Adapted the module due to the refactoring of base_location. Adapted tests.
Currently translated at 100.0% (23 of 23 strings) Translation: partner-contact-12.0/partner-contact-12.0-base_location_geonames_import Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_location_geonames_import/es/
If there are several cities with the same name in different states, previous code doesn't handle correctly this situation. We amend this storing in the cached dictionary both city name and state. Includes a test for checking this specific condition, got from real data in US. Fixes OCA#749
Currently translated at 100.0% (23 of 23 strings) Translation: partner-contact-12.0/partner-contact-12.0-base_location_geonames_import Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_location_geonames_import/pt_BR/
Standard procedure
[W0622(redefined-builtin), TestBaseLocationGeonamesImport.test_import_title] Redefining built-in 'zip'
* Performance was very poor due to several reasons: * City name translatable. * Lack on indexes when deleting obsolete records. * Some prefetching. * City was not being searched also by state, having the chance of returning incorrect matches if same city name on different states. * Previous code was removing all previous records of zip entries! * Remove possible obsolete FK keys after migrating from v11.
Introducing second variable has provoked an error on that part.
…s through the same wizard
Currently translated at 100.0% (24 of 24 strings) Translation: partner-contact-13.0/partner-contact-13.0-base_location_geonames_import Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-base_location_geonames_import/pt_BR/
In that case, using remove would raise a KeyError. On the other hand, discard fails silently.
- Standard procedure TT32981
Currently translated at 100.0% (25 of 25 strings) Translation: partner-contact-16.0/partner-contact-16.0-base_location_geonames_import Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location_geonames_import/es/
Currently translated at 96.0% (24 of 25 strings) Translation: partner-contact-16.0/partner-contact-16.0-base_location_geonames_import Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location_geonames_import/it/
Currently translated at 100.0% (25 of 25 strings) Translation: partner-contact-16.0/partner-contact-16.0-base_location_geonames_import Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location_geonames_import/it/
Currently translated at 100.0% (25 of 25 strings) Translation: partner-contact-16.0/partner-contact-16.0-base_location_geonames_import Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-base_location_geonames_import/pt_BR/
- Standard procedure. - Tests adapted for not blocking external requests. TT48121
Currently translated at 100.0% (25 of 25 strings) Translation: partner-contact-17.0/partner-contact-17.0-base_location_geonames_import Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-base_location_geonames_import/sv/
Currently translated at 100.0% (25 of 25 strings) Translation: partner-contact-17.0/partner-contact-17.0-base_location_geonames_import Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-base_location_geonames_import/ca/
Kimkhoi3010
force-pushed
the
18.0-mig-base_location_geonames_import
branch
from
1ab0433 to
a9f127e
Compare
chaule97
reviewed
Oct 15, 2024
|
|
||
| import requests | ||
|
|
||
| from odoo import _, api, fields, models |
There was a problem hiding this comment.
Suggested change
| from odoo import _, api, fields, models | |
| from odoo import api, fields, models |
Comment on lines
108
to
114
| raise UserError( | ||
| _("Got an error %d when trying to download the file %s.") | ||
| % (res_request.status_code, url) | ||
| ) |
There was a problem hiding this comment.
Suggested change
| raise UserError( | |
| _("Got an error %d when trying to download the file %s.") | |
| % (res_request.status_code, url) | |
| ) | |
| raise UserError( | |
| self.env._("Got an error %d when trying to download the file %s.", res_request.status_code, url) | |
| ) |
| try: | ||
| item.unlink() | ||
| except Exception: | ||
| logger.info(_("%d could not be deleted %") % item.name) |
There was a problem hiding this comment.
Suggested change
| logger.info(_("%d could not be deleted %") % item.name) | |
| logger.info(self.env._("%s could not be deleted %", item.name)) |
Kimkhoi3010
force-pushed
the
18.0-mig-base_location_geonames_import
branch
2 times, most recently
from
9a0fab4 to
393a4a9
Compare
chaule97
reviewed
Oct 15, 2024
| ) | ||
| except Exception: | ||
| for item in items: | ||
| try: | ||
| item.unlink() | ||
| except Exception: | ||
| logger.info(_("%d could not be deleted %") % item.name) | ||
| logger.info(self.env._("%d could not be deleted %", item.name)) |
There was a problem hiding this comment.
Suggested change
| logger.info(self.env._("%d could not be deleted %", item.name)) | |
| logger.info(self.env._("%s could not be deleted", item.name)) |
There was a problem hiding this comment.
item.name is string, so we replace %d to %s
Kimkhoi3010
force-pushed
the
18.0-mig-base_location_geonames_import
branch
4 times, most recently
from
93baf8a to
39788fe
Compare
chaule97
approved these changes
Oct 15, 2024
Kimkhoi3010
force-pushed
the
18.0-mig-base_location_geonames_import
branch
from
39788fe to
6908dd9
Compare
Kimkhoi3010
force-pushed
the
18.0-mig-base_location_geonames_import
branch
3 times, most recently
from
5308374 to
712137a
Compare
Befor this commit, there were 2 possible errors re-importing ZIPs: - If city names are changed on the import process (like capitalization), the code for detecting existing entries was not taking that into account, failing to find the city. - If there's more than one found result, using `discard` for removing the result from the ZIPs to remove gives an error. TT52020
Kimkhoi3010
force-pushed
the
18.0-mig-base_location_geonames_import
branch
from
712137a to
9d9eac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: [18.0][MIG] base_location: Migration to 18.0
It found only 1 commit to port:
It was ignored, I added them to blacklist: 8eccd39